RFR: 8257733: Move module-specific data from make to respective module [v9]
Magnus Ihse Bursie
ihse at openjdk.java.net
Mon Mar 21 14:15:36 UTC 2022
On Fri, 18 Mar 2022 21:24:43 GMT, Phil Race <prr at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typos
>
> This doesn't seem right to me to put x11wrappergen into share.
>
> This is X11 specific. It should not be in share.
>
> Same for all of the fontconfig files. In make/data it did not seem too weird but it is very weird to put them all in share. If you were to go back and look how it used to be before someone moved them to make I am sure you'd find them in platform specific source directories.
@prrace I have now moved the fontconfig files to `$OS/data`. (I also took the opportunity to clean up the GenData file, which had a quite hairy logic for a trivial task.) I have moved the x11wrappergen files to `unix/data`.
(Strictly speaking, "unix" and "x11" do not have the same "sense" (in the Fregean meaning), even if it has the same "referent". But we've used that convention before so I'm sticking to it.)
-------------
PR: https://git.openjdk.java.net/jdk/pull/1611
More information about the security-dev
mailing list