RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368

Sean Coffey coffeys at openjdk.java.net
Tue Mar 22 12:31:36 UTC 2022


On Tue, 22 Mar 2022 00:24:41 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java line 130:
>> 
>>> 128:      * The following is to set up the keystores/trust material.
>>> 129:      */
>>> 130:     private static final String pathToStores = "../../../../javax/net/ssl/etc";
>> 
>> I think the advise is to move away from binary style keystores. i.e. to use test/jdk/javax/net/ssl/templates/SSLContextTemplate.java for a replacement. Is that possible here ?
>
> Sigh...this is a whole can of worms I wasn't expecting.  Looks like one person did the SSLContextTemplate and updated with SSLEngineTemplate, then another person took a completely different takes with SSLSocketTemplate, and then SSLSocketSSLEngineTemplate didn't get touched at all.  
> 
> This should really be harmonized.  :(

ouch - maybe this should be fixed up in a separate bug then. Don't think it should be a blocker for this fix

-------------

PR: https://git.openjdk.java.net/jdk/pull/7796



More information about the security-dev mailing list