RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]
Bradford Wetmore
wetmore at openjdk.java.net
Wed Mar 23 17:01:12 UTC 2022
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal internal_error (80) and invalidate existing sessions (either completed or under construction) as described in (RFC 4346/TLSv1.1+) if a connection was closed without receiving a close_notify alert from the peer.
>
> This change introduces similar behavior to SSLEngine.
>
> The unit test checks that closing the read(input) sides of the SSLSocket/SSLEngine throws an SSLException, but doesn't invalidate their respective sessions.
>
> Tier1/2 mach5 tests have been successfully run.
Bradford Wetmore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
- Code review comment: enclose conContext.closeInbound() in a try/finally block.
- Merge branch 'master' into JDK-8273553
- Merge branch 'master' into JDK-8273553
- Added SSLSocket bugid since we're actually checking both sides now.
- I/O Issues, rewrite the I/O section so that early Socket closes don't kill our server-side reads.
- Merge branch 'master' into JDK-8273553
- Merge branch 'master' into JDK-8273553
- Merge
- Minor test tweaks.
- Remove inadvertent whitespace
- ... and 2 more: https://git.openjdk.java.net/jdk/compare/84577bde...b2f64d92
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7796/files
- new: https://git.openjdk.java.net/jdk/pull/7796/files/43953018..b2f64d92
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7796&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7796&range=00-01
Stats: 4167 lines in 793 files changed: 2485 ins; 1099 del; 583 mod
Patch: https://git.openjdk.java.net/jdk/pull/7796.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7796/head:pull/7796
PR: https://git.openjdk.java.net/jdk/pull/7796
More information about the security-dev
mailing list