RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

Thu Mar 24 06:57:48 UTC 2022

On Thu, 24 Mar 2022 06:48:00 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>>> @XueleiFan, I'm not following your first comment.
>> 
>> Sorry for that.  I was wondering something new in the future, which is not doable in the current Java language.  Please just leave it alone.
>
> Ah!  Thanks.

> IIUC, you are suggesting:
> ... snipped ...

Yes.

> What is the advantage to changing to this style, other than a very small performance win by not locking in the already closed case?

The advantage is mainly about the performance, as I/O of SSLLogger could be slow.  The SSLSocketImpl code does not put the similar block locked.  But it may be not the purpose of this update. I'm fine if you want to leave it alone.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7796