RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

[Maurizio Cimadamore]

On Thu, 24 Mar 2022 19:17:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> I'd suggest at least adding `--enable-preview` as an argument when running benchmarks through the build system in that case. I think this should do the trick:
>> 
>> 
>> diff --git a/make/RunTests.gmk b/make/RunTests.gmk
>> index 81540266ec0..9ed45fb02a8 100644
>> --- a/make/RunTests.gmk
>> +++ b/make/RunTests.gmk
>> @@ -583,7 +583,7 @@ define SetupRunMicroTestBody
>>    $$(eval $$(call SetMicroValue,$1,MICRO_JAVA_OPTIONS))
>> 
>>    # Current tests needs to open java.io
>> -  $1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED
>> +  $1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED --enable-preview
>> 
>>    # Save output as JSON or CSV file
>>    ifneq ($$(MICRO_RESULTS_FORMAT), )
>> 
>> 
>> People manually running the benchmarks.jar will have to pass `--enable-preview` still though.
>
> After discussing this offline, it seems that javac no longer poisons the minor class file version of every class file, but only of those that use preview features. So, my concern is not warranted.

Turns out this is no longer necessary. As part of the support for preview API, javac now only pollutes the classfile if a source file is using preview features, as described in this PR:
https://github.com/openjdk/jdk/pull/703

-------------

PR: https://git.openjdk.java.net/jdk/pull/7888