RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v2]

[Valerie Peng]

On Thu, 24 Mar 2022 20:30:20 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated to address review feedbacks.
>
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 74:
> 
>> 72:  *     TrailerField -- 1
>> 73:  *
>> 74:  * <p>Its values are based on the default values in the ASN.1 encoding
> 
> Maybe "defined in the ASN.1..."?

Sure.

> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 75:
> 
>> 73:  *
>> 74:  * <p>Its values are based on the default values in the ASN.1 encoding
>> 75:  * from PKCS#1 standard and may become obsolete as time progresses.
> 
> Either "the PKCS#1 standard" or simply "PKCS#1" sounds good, but "PKCS#1 standard" without "the"?

Ok, I will add "the".

> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 76:
> 
>> 74:  * <p>Its values are based on the default values in the ASN.1 encoding
>> 75:  * from PKCS#1 standard and may become obsolete as time progresses.
>> 76:  * Please do not rely on PSSParameterSpec.DEFAULT unless these values are
> 
> Put `PSSParameterSpec.DEFAULT` in `{@code...}`?

Yes, will do.

> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 112:
> 
>> 110:      * @deprecated This field uses the default values defined in the ASN.1
>> 111:      *         encoding in PKCS#1 which may become obsolete as time progresses.
>> 112:      *         Thus, it is recommended to create a new PSSParameterSpec object
> 
> Should `PSSParameterSpec` be inside a `{@code ...}`?

Yes, good catch. Will fix. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7913