RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v5]

Weijun Wang weijun at openjdk.java.net
Fri Mar 25 01:37:55 UTC 2022


On Thu, 24 Mar 2022 23:34:30 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Can someone help review this update to the PSSParameterSpec class regarding the constructor with int argument and the DEFAULT static field? Just added @Deprecate javadoc tag and caution about their usage as suggested in the bug record.
>> 
>> A CSR will be filed once the wording changes are reviewed.
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More minor edits.

src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 78:

> 76:  * Please do not rely on {@code PSSParameterSpec.DEFAULT} unless these
> 77:  * values are really what you want to use.
> 78:  *

I just read the whole class spec. Since the default values are already included on lines 38-41, I think there is no need to use so much words and we can just say "defined above".

-------------

PR: https://git.openjdk.java.net/jdk/pull/7913



More information about the security-dev mailing list