RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v5]

Sat Mar 26 00:30:43 UTC 2022

On Fri, 25 Mar 2022 21:49:07 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> I am not sure if everyone reads the complete spec from class to fields and methods. Which part do you want to remove and just use "defined above"? Personally, I find "above" kind of vague... It's better to keep the comment near the field. Perhaps we should trim the class spec instead?
>
> Almost the whole class spec is copied from PKCS #1 but at the end you have "defined in the ASN.1 encoding from the PKCS#1 standard", which might make people wonder if it is something else. If you don't want to remove anything, how about "defined in the ASN.1 encoding from the PKCS#1 standard above". It's verbose but not confusing.
> 
> BTW, on https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/security/spec/PSSParameterSpec.html, the whole "Note" is shown on one line. I guess that's not intended.

Ah, Ok, I think I see what you are saying now. I agree about trimming the class spec. Are you ok with removing line 67-77 (proposed/new version)? This would reduce the duplication of wordings.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7913