RFR: 8285516: clearPassword should be called in a finally try block [v3]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Thu May 5 06:02:14 UTC 2022
> Hi,
>
> Could I have the simple update reviewed?
>
> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() should be called in a finally try block. Otherwise, the password cleanup could be interrupted by exceptions.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge
- an extra whitespace added
- 8285516: clearPassword should be called in a finally try block
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8377/files
- new: https://git.openjdk.java.net/jdk/pull/8377/files/99079d30..1df828df
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8377&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8377&range=01-02
Stats: 32346 lines in 832 files changed: 22171 ins; 4511 del; 5664 mod
Patch: https://git.openjdk.java.net/jdk/pull/8377.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8377/head:pull/8377
PR: https://git.openjdk.java.net/jdk/pull/8377
More information about the security-dev
mailing list