RFR: 8209038: Clarify the javadoc of Cipher.getParameters() [v5]
Valerie Peng
valeriep at openjdk.java.net
Wed May 11 22:32:48 UTC 2022
On Tue, 10 May 2022 20:38:31 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Valerie Peng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8209038
>> - update to address review feedback and minor javadoc cleanup
>> - Update for getParameters()
>> - Update w/ review feedbacks
>> - 8209038: Clarify the javadoc of Cipher.getParameters()
>
> src/java.base/share/classes/javax/crypto/CipherSpi.java line 294:
>
>> 292: * values used by the underlying cipher implementation. If the required
>> 293: * parameters were not supplied and can be generated by the cipher, the
>> 294: * generated parameters will be returned. Otherwise, {@code null} is
>
> Minor wording nit - change "will be" to "are" to be consistent with other wording which uses the present tense. Same comment applies to `Cipher.getParameters`.
Yes, will fix the nit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8117
More information about the security-dev
mailing list