RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Thu May 12 04:40:49 UTC 2022


On Wed, 11 May 2022 22:49:02 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/javax/net/ssl/SSLEngine.java line 677:
>> 
>>> 675:      * @see     #unwrap(ByteBuffer, ByteBuffer[], int, int)
>>> 676:      *
>>> 677:      * @implNote The data in {@code src} may be modified during the decryption
>> 
>> It looks like a note for the API users to me.  Is apiNote tag more appropriate here?
>
> The CSR and this code is changing, the note I was adding was already documented, but its existing wording should be more clear.

I like the new update as specified in the CSR.  I added my name as Reviewer for the CSR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8462



More information about the security-dev mailing list