RFR: 8002277: Refactor two PBE classes to simplify maintenance [v7]
Sean Mullan
mullan at openjdk.java.net
Thu May 12 19:32:36 UTC 2022
On Thu, 12 May 2022 03:28:15 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> This change refactors the PBES2Core and PKCS12PBECipherCore classes in SunJCE provider as requested in the bug record. Functionality should remain the same with a clearer and simplified code/control flow with less lines of code. This should improve readability and maintenance. I enhanced one existing regression test to test more scenarios. This test would pass before the proposed change and continues to pass with the proposed changes.
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>
> trivial syntax fix.
src/java.base/share/classes/com/sun/crypto/provider/PBES2Core.java line 184:
> 182: "Iteration count must be a positive number");
> 183: }
> 184: return iCount == 0? DEFAULT_COUNT : iCount;
Nit: add space before '?'.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8521
More information about the security-dev
mailing list