RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer

[Bradford Wetmore]

On Wed, 11 May 2022 22:25:43 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> test/jdk/javax/net/ssl/SSLSession/ReadOnlyEngine.java line 1:
>> 
>>> 1: /*
>> 
>> Wondering why this is in javax/net/ssl/SSLSession instead of sun/security/ssl/SSLCipher.
>
> I can move it.. I created it from another test which happen to be in that directory

Ah.  If you can, please do.  Thanks.

>> test/jdk/javax/net/ssl/SSLSession/ReadOnlyEngine.java line 157:
>> 
>>> 155:         // Do TLS handshake
>>> 156:         do {
>>> 157:             statusClient = doHandshake(client, out, in);
>> 
>> It's potentially a little inefficient returning after each wrap/unwrap() instead of doing the task right away, but it works.  No need to change.
>> 
>> Is this style something you copied from another test?  The  SSLEngineTemplate in the templates directory is what I often use.
>
> I got it from somewhere that I don't remember off hand.  I'm just trying to get through the handshake.

It was just an observation, no need to change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8462