RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]
Valerie Peng
valeriep at openjdk.java.net
Mon May 16 23:18:21 UTC 2022
On Mon, 16 May 2022 13:28:13 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> With this modification of 2nd sentence. The whole paragraph becomes:
>>
>> * <p>The returned parameters may be the same that were used to initialize
>> * this signature, or may contain additional default or random parameter
>> * values used by the underlying signature scheme. If the required
>> * parameters were not supplied and can be generated by the signature,
>> * the generated parameters are returned; otherwise {@code null} is
>> * returned. However, if the signature scheme does not support returning
>> * the parameters as {@code AlgorithmParameters}, {@code null} is always
>> * returned.
>>
>> For the last sentence, would it be better to use "also" instead of "always"?
>
> I think "also" would not be quite right, because I would read that as there is something else that is also returned with `null`. I think you can remove the word "always" -- it isn't really necessary and that might address your concern.
Max suggested moving the last sentence to a new paragraph, so I did that and leave the "always" in.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8396
More information about the security-dev
mailing list