RFR: 8286908: ECDSA signature should not return parameters

Anthony Scarpino ascarpino at openjdk.java.net
Tue May 17 21:25:55 UTC 2022


On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Let ECDSA's `engineGetParameters()` always return null. At the same time, remove the remembered `sigParams` field. One behavior change is that after calling `setParameter()`, one can call `init()` again with a key using different parameters. I think this should be allowed since we are reusing the signature object with a brand new key.
> 
> `setParameter` is kept unchanged to be able to deal with certificates still having parameters after the signature algorithm object identifier. See https://bugs.openjdk.java.net/browse/JDK-8225745.
> 
> Also added SHA1withECDSA to the no-NULL list in `KnownOIDs`.
> 
> All security-related tests passed.

Marked as reviewed by ascarpino (Reviewer).

Looks good to me.
The changes seem within the spec to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8758



More information about the security-dev mailing list