Integrated: 8283577: SSLEngine.unwrap on read-only input ByteBuffer

Anthony Scarpino ascarpino at openjdk.java.net
Tue May 17 21:42:07 UTC 2022


On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a review of this fix to allow a read-only 'src' buffer to be used with SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher operation when a read-only buffer is passed. If the 'src' is read-write, there is no effect on the current operation
> 
> The PR also includes a CSR for an API implementation note to the SSLEngine.unwrap. The 'src' buffer may be modified during the decryption operation. 'unwrap()' has had this behavior forever, so there is no compatibility issue with this note. Using the 'src' buffer for in-place decryption was a performance decision.
> 
> Tony

This pull request has now been integrated.

Changeset: f17c68ce
Author:    Anthony Scarpino <ascarpino at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/f17c68ce4a0b4f5c3131f4e4626a5a55b7f2f61f
Stats:     393 lines in 3 files changed: 291 ins; 20 del; 82 mod

8283577: SSLEngine.unwrap on read-only input ByteBuffer

Reviewed-by: wetmore

-------------

PR: https://git.openjdk.java.net/jdk/pull/8462



More information about the security-dev mailing list