RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v9]

Weijun Wang weijun at openjdk.java.net
Tue May 17 23:14:56 UTC 2022


On Tue, 17 May 2022 22:22:36 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This is to update the method javadoc of java.security.Signature.getParameters() with the missing `@throws UnsupportedOperationException`. In addition, the wording on the returned parameters are updated to match those in Cipher and CipherSpi classes. 
>> 
>> CSR will be filed later.
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more minor cleanups for consistencies.

src/java.base/share/classes/java/security/SignatureSpi.java line 377:

> 375:      *
> 376:      * <p>This method is overridden by providers to initialize
> 377:      * this signature object with the specified parameter set.

1st paragraph: values, 2nd: set. Make them the same.

src/java.base/share/classes/java/security/SignatureSpi.java line 397:

> 395:      *
> 396:      * <p>This method is overridden by providers to return the parameters
> 397:      * used with this signature object.

The 2 paragraphs above look the same. Of course, if you believe the 1st paragraph should always be a simple description, that's OK.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8396



More information about the security-dev mailing list