RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v7]
Mark Powers
duke at openjdk.java.net
Thu May 19 00:38:43 UTC 2022
On Wed, 18 May 2022 04:47:13 GMT, Mark Powers <duke at openjdk.java.net> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the umbrella bug for this bug. The changes were too large for a single code review, so it was decided to split into smaller chunks. This is one such chunk:
>>
>> open/src/java.security.jgss/share/classes/javax/security
>> open/src/java.security.jgss/share/classes/org/ietf
>> open/src/java.security.jgss/share/classes/sun/security
>
> Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:
>
> - Merge
> - reverse IntelliJ unboxing suggestion
> - Merge
> - Merge
> - Merge
> - Brad comments
> - Max comments
> - sixth iteration
> - Merge
> - fifth iteration
> - ... and 8 more: https://git.openjdk.java.net/jdk/compare/2ed75be6...30ca27a2
IntelliJ complains that unboxed values should be boxed, e.g. `Integer.valueOf()` should be changed to `Integer`. After some discussion, it has been decided to ignore IntelliJ's complaints and leave the code as written. To box or unbox is a matter of personal preference. The generated byte code is the same either way.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7746
More information about the security-dev
mailing list