RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

Matthias Baesken mbaesken at openjdk.org
Tue Nov 8 15:19:38 UTC 2022


On Tue, 8 Nov 2022 14:01:29 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite a lot of code duplication. The test code can be simplified e.g. by using generics. Additionally the test failure output was improved and a test for the constructors of CertPathBuilderException was added.
>
> test/jdk/java/security/Exceptions/ChainingConstructors.java line 208:
> 
>> 206:             throw new SecurityException("Test 17 failed");
>> 207:         }
>> 208: */
> 
> I don't know why this is commented out, but when I uncomment it, the test still passes, so I would include a test for `SSLException` below.

Hi Sean,  the summary says that the test is about  "java.security Exceptions" so  javax.net.ssl.SSLException.java from another package might not fit in, maybe that's why it was commented out.
Should I still add it ? If so, the  summary comment might need a little bit adjustment, what about this "Test constructors for exception chaining of  security-related exceptions"  ?

-------------

PR: https://git.openjdk.org/jdk/pull/11016



More information about the security-dev mailing list