RFR: 8293886: The abstract keyword can be removed in AESCipher

Anthony Scarpino ascarpino at openjdk.org
Wed Nov 9 21:49:46 UTC 2022


On Fri, 16 Sep 2022 00:27:55 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> Please review this simple fix for readability.
> 
> In the AES cipher implementation, the AESCipher class is defined as abstract.  As is not necessary as there is no abstract method in this class. Code reader may try to search for abstract methods if the abstract keyword is present.
> 
> BTW, I also added Override tags and make a few other cleanup, for example adding the 'final' keywords.
> 
> Thanks,
> Xuelei

The change looks fine

-------------

Marked as reviewed by ascarpino (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10297


More information about the security-dev mailing list