RFR: 8293886: The abstract keyword can be removed in AESCipher
Xue-Lei Andrew Fan
xuelei at openjdk.org
Thu Nov 10 01:35:31 UTC 2022
On Thu, 10 Nov 2022 00:23:47 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Hi,
>>
>> Please review this simple fix for readability.
>>
>> In the AES cipher implementation, the AESCipher class is defined as abstract. As is not necessary as there is no abstract method in this class. Code reader may try to search for abstract methods if the abstract keyword is present.
>>
>> BTW, I also added Override tags and make a few other cleanup, for example adding the 'final' keywords.
>>
>> Thanks,
>> Xuelei
>
> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 61:
>
>> 59: */
>> 60:
>> 61: class AESCipher extends CipherSpi {
>
> If you're doing general cleaning, line 33 import ByteBuffer can go, and there's an extra line in the javadoc at line 53 that could also go.
Yes. I will make the cleanup as well.
-------------
PR: https://git.openjdk.org/jdk/pull/10297
More information about the security-dev
mailing list