RFR: 8296736: Some PKCS9Attribute can be created but cannot be encoded

Weijun Wang weijun at openjdk.org
Thu Nov 10 02:43:22 UTC 2022


On Wed, 9 Nov 2022 21:54:49 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> One `PKCS9Attribute` can be created but cannot be encoded. Since the `SigningCertificateInfo::parse` method has not fully parsed the data (`PolicyInformation` is left out), this code change add the encoding itself as a field to the `SigningCertificateInfo` class so we can encode it.
> 
> After this change, unsupported `PKCSAttribute` object simply cannot be created. The `new(DerValue)` constructor rejects them (type 9-13, 15) in a `switch` block, and the `new(ObjectIdentifier, Object)` constructor rejects them because `VALUE_CLASSES` for them are null.
> 
> In the `encode()` method, we now throw `IllegalArgumentException` for these types and they will not happen.

New commit. I also put `ESSCertId` as an inner class. Having 2 top level classes in the same file feel weird.

-------------

PR: https://git.openjdk.org/jdk/pull/11070



More information about the security-dev mailing list