RFR: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters [v2]

Weijun Wang weijun at openjdk.org
Thu Nov 10 15:27:52 UTC 2022


> An `EncryptedPrivateKeyInfo` object can be created with an uninitialized `AlgorithmParameters`, but before you call `getEncoded` on it you need to remember to initialize the params. This is unfortunate but since this is a public API, I hesitate to make a change.
> 
> Instead, this code change fixes the much more widely used internal class `AlgorithmId` so that it cannot be created with an uninitialized `AlgorithmParameters`. `EncryptedPrivateKeyInfo` now works with both initialized and uninitialized params, and it's immutable.
> 
> No intention to make `AlgorithmId` immutable this time. It has a child class named `AlgIdDSA` which makes things complicated.

Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:

  address xuelei's comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11067/files
  - new: https://git.openjdk.org/jdk/pull/11067/files/f80794c4..499f50a8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11067&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11067&range=00-01

  Stats: 50 lines in 2 files changed: 6 ins; 37 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/11067.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11067/head:pull/11067

PR: https://git.openjdk.org/jdk/pull/11067



More information about the security-dev mailing list