RFR: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters [v2]

Weijun Wang weijun at openjdk.org
Thu Nov 10 17:52:36 UTC 2022


On Thu, 10 Nov 2022 16:41:13 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address xuelei's comments
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 187:
> 
>> 185:             throw new NullPointerException("algParams must be non-null");
>> 186:         }
>> 187:         AlgorithmId tmp;
> 
> style-comment: meaningful variable names should be preferred (ie- choose something other than `tmp`)

I don't usually use tmp as variable names, but when I do, it's indeed temporary and will be discarded within 8 lines (comment and empty lines not counted). :-D

-------------

PR: https://git.openjdk.org/jdk/pull/11067


More information about the security-dev mailing list