Integrated: 8293886: The abstract keyword can be removed in AESCipher

Xue-Lei Andrew Fan xuelei at openjdk.org
Thu Nov 10 17:55:30 UTC 2022


On Fri, 16 Sep 2022 00:27:55 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> Please review this simple fix for readability.
> 
> In the AES cipher implementation, the AESCipher class is defined as abstract.  As is not necessary as there is no abstract method in this class. Code reader may try to search for abstract methods if the abstract keyword is present.
> 
> BTW, I also added Override tags and make a few other cleanup, for example adding the 'final' keywords.
> 
> Thanks,
> Xuelei

This pull request has now been integrated.

Changeset: d6468be8
Author:    Xue-Lei Andrew Fan <xuelei at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d6468be81fd2d639d5d79898d3cd8042d62261bd
Stats:     29 lines in 1 file changed: 18 ins; 4 del; 7 mod

8293886: The abstract keyword can be removed in AESCipher

Reviewed-by: ascarpino, wetmore

-------------

PR: https://git.openjdk.org/jdk/pull/10297



More information about the security-dev mailing list