RFR: 8296612: CertAttrSet is useless

Weijun Wang weijun at openjdk.org
Thu Nov 10 20:48:40 UTC 2022


On Thu, 10 Nov 2022 20:24:31 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> - All `CertAttrSet` child classes now implement `DerEncoder`
>> - `DerEncoder::derEncode` is renamed to `DerEncoder::encode`, and duplicate methods are removed
>> - `s.s.x.Extension` now implements `DerEncoder`, so its child classes no need to implement it
>> - `X509CertImpl::encode(OutputStream out)` removed, used nowhere
>
> src/java.base/share/classes/sun/security/util/DerEncoder.java line 43:
> 
>> 41:      * @param out  the stream on which the DER encoding is written.
>> 42:      */
>> 43:     void encode(DerOutputStream out)
> 
> Add `@Override`.

Not this one. :-)

-------------

PR: https://git.openjdk.org/jdk/pull/11048



More information about the security-dev mailing list