RFR: 8295146: Clean up native code with newer C/C++ language features [v2]

Julian Waters jwaters at openjdk.org
Mon Nov 14 04:14:26 UTC 2022


On Sun, 13 Nov 2022 22:58:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ATTRIBUTE_SCANF
>
> src/hotspot/os/linux/os_perf_linux.cpp line 233:
> 
>> 231:  *  Ensure that 'fmt' does _NOT_ contain the first two "%d %s"
>> 232:  */
>> 233: SCANF_ARGS(2, 0) static int vread_statdata(const char* procfile, _SCANFMT_ const char* fmt, va_list args) {
> 
> If `SCANF_ARGS` can/must come first then I suggest adding a newline after it so the method signature is easier to spot. Applied everywhere of course.

Resolved, thanks

-------------

PR: https://git.openjdk.org/jdk/pull/11081



More information about the security-dev mailing list