RFR: 8296736: Some PKCS9Attribute can be created but cannot be encoded [v3]
Valerie Peng
valeriep at openjdk.org
Tue Nov 15 00:56:04 UTC 2022
On Mon, 14 Nov 2022 22:19:32 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> One `PKCS9Attribute` can be created but cannot be encoded. Since the `SigningCertificateInfo::parse` method has not fully parsed the data (`PolicyInformation` is left out), this code change add the encoding itself as a field to the `SigningCertificateInfo` class so we can encode it.
>>
>> After this change, unsupported `PKCSAttribute` object simply cannot be created. The `new(DerValue)` constructor rejects them (type 9-13, 15) in a `switch` block, and the `new(ObjectIdentifier, Object)` constructor rejects them because `VALUE_CLASSES` for them are null.
>>
>> In the `encode()` method, we now throw `IllegalArgumentException` for these types and they will not happen.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> different message for null encoded
Marked as reviewed by valeriep (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/11070
More information about the security-dev
mailing list