RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v2]

Tue Nov 15 15:06:05 UTC 2022

On Tue, 15 Nov 2022 14:15:26 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>> 
>>> 316:         }
>>> 317:     }
>>> 318:     @Hidden
>> 
>> Can we rename this to runWith(Runnable, Object) in both Thread and VirtualThread to keep the naming consistent if we can?
>
> OK. I do want to keep the name of this method consistent throughout. There are version for `Runnable` and `Callable` and it makes the runtime code cleaner if they have the same name.

The other thing here is that there two calls to reachabilityFence, it shouldn't need both.

-------------

PR: https://git.openjdk.org/jdk/pull/10952