RFR: 8296901: Do not create unsigned certificate and CRL [v2]

Andrey Turbanov aturbanov at openjdk.org
Wed Nov 16 08:10:57 UTC 2022


On Tue, 15 Nov 2022 02:50:10 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Instead if creating an "unsigned" `X509CertImpl` with only an `X509CertInfo` inside, a new static method `signNew` is introduced to create a newly signed certificate from an `X509CertInfo` object and a `PrivateKey`. Thus make sure an `X509CertImpl` is always signed and there is no read to keep its `readOnly` flag.
>> 
>> The same for `X509CRLImpl`. A new inner class `TBSCertList` is added which is equivalent to `X509CertInfo` inside `X509CertImpl`.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   a method called by test

src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 1324:

> 1322:         throws CertificateParsingException {
> 1323:         // return cached value if we can
> 1324:         if (subjectAlternativeNames != null)  {

Suggestion:

        if (subjectAlternativeNames != null) {

-------------

PR: https://git.openjdk.org/jdk/pull/11151


More information about the security-dev mailing list