RFR: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters [v5]
Sean Mullan
mullan at openjdk.org
Wed Nov 16 20:30:14 UTC 2022
On Wed, 16 Nov 2022 18:47:27 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> An `EncryptedPrivateKeyInfo` object can be created with an uninitialized `AlgorithmParameters`, but before you call `getEncoded` on it you need to remember to initialize the params. This is unfortunate but since this is a public API, I hesitate to make a change.
>>
>> Instead, this code change fixes the much more widely used internal class `AlgorithmId` so that it cannot be created with an uninitialized `AlgorithmParameters`. `EncryptedPrivateKeyInfo` now works with both initialized and uninitialized params, and it's immutable.
>>
>> No intention to make `AlgorithmId` immutable this time. It has a child class named `AlgIdDSA` which makes things complicated.
>
> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - more comments
> - Merge branch 'master' into 8296442
> - comment and exception message
> - expected
> - address xuelei's comments
> - the fix
Marked as reviewed by mullan (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/11067
More information about the security-dev
mailing list