RFR: 8296408: Make the PCSCException public accessible

Johannes Waigel duke at openjdk.org
Wed Nov 16 22:37:57 UTC 2022


On Sun, 13 Nov 2022 19:41:52 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> The `PCSCException` is thrown, but the error type is not visible due to the "private-packe" access rule.
>> By changing the visibility it is possible to handle / access this exception type explicitly in the catch.
>
> src/java.smartcardio/share/classes/sun/security/smartcardio/PCSCException.java line 38:
> 
>> 36:  * @author  Andreas Sterbenz
>> 37:  */
>> 38: final public class PCSCException extends Exception {
> 
> Use blessed modifiers order
> Suggestion:
> 
> public final class PCSCException extends Exception {

Thank you for feedback, I have adjusted the order

-------------

PR: https://git.openjdk.org/jdk/pull/11012


More information about the security-dev mailing list