RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v2]

Weijun Wang weijun at openjdk.org
Fri Nov 18 15:50:37 UTC 2022


On Fri, 18 Nov 2022 03:57:32 GMT, pandaapo <duke at openjdk.org> wrote:

>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Remove some unused methods and refactor some reldated codes.
>  - Merge branch 'master' into master-JDK-8296734
>  - Make signerToCodeSource cache work.

src/java.base/share/classes/java/util/jar/JavaUtilJarAccessImpl.java line 43:

> 41:     }
> 42: 
> 43:     public CodeSource[] getCodeSources(JarFile jar, URL url) {

After you remove these methods, some imports at the beginning can also be removed.

-------------

PR: https://git.openjdk.org/jdk/pull/11072



More information about the security-dev mailing list