RFR: 8296024: Usage of DIrectBuffer::address should be guarded [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Nov 21 12:20:05 UTC 2022


On Mon, 21 Nov 2022 12:03:35 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/zip/Adler32.java line 102:
>> 
>>> 100:             return;
>>> 101:         if (buffer.isDirect()) {
>>> 102:             try (var sessionAcquisition = NIO_ACCESS.acquireSessionAsAutoCloseable(buffer)) {
>> 
>> We need to find something better than "sessionAcquisition", it looks very messy at all these use sites.
>
> Eventually, I hope most of them will be named `_`.

maybe just `bufferLock` and and just `acquireBuffer` ?

-------------

PR: https://git.openjdk.org/jdk/pull/11260



More information about the security-dev mailing list