RFR: 8296024: Usage of DIrectBuffer::address should be guarded [v4]

Mon Nov 21 13:49:09 UTC 2022

On Mon, 21 Nov 2022 13:32:43 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename methods
>
> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 41:
> 
>> 39:     // An example of a guarded use of a memory address is shown here:
>> 40:     //
>> 41:     // try (var guard = NIO_ACCESS.acquireSessionAsAutoCloseable(bb)) {
> 
> Suggestion:
> 
>     // try (var guard = NIO_ACCESS.acquireSession(bb)) {

Are you happy with the proposed renaming now @ExE-Boss ? I think our propositions crossed in time?

-------------

PR: https://git.openjdk.org/jdk/pull/11260