RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

Anthony Scarpino ascarpino at openjdk.org
Mon Nov 21 18:20:14 UTC 2022


On Wed, 16 Nov 2022 17:01:50 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comment cleanup & finesse ByteBuffer implGCMCrypt better
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 603:
> 
>> 601:         }
>> 602: 
>> 603:         // Finish any remaining data
> 
> comment doesn't add anything special

ok

> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1644:
> 
>> 1642:                 // Clear output data
>> 1643:                 dst.reset();
>> 1644:                 // If this is an in-place array, don't zero the src
> 
> The comment doesn't jive with the line of code on the next line. It is the inverse of the comment.

ok

-------------

PR: https://git.openjdk.org/jdk/pull/11121



More information about the security-dev mailing list