RFR: 8296742: Illegal X509 Extension should not be created [v8]

Tue Nov 22 20:43:23 UTC 2022

On Tue, 22 Nov 2022 19:53:44 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   IssuerAlternativeNameExtension names
>
> src/java.base/share/classes/sun/security/x509/SubjectAlternativeNameExtension.java line 91:
> 
>> 89:      */
>> 90:     public SubjectAlternativeNameExtension(Boolean critical, GeneralNames names)
>> 91:             throws IOException {
> 
> `GeneralNames` should probably also be modified so that it cannot contain an empty or null List.

It still has `add` which is used in multiple places. I'll see if I can remove this method and make it immutable.

-------------

PR: https://git.openjdk.org/jdk/pull/11137