RFR: 8294248: Use less limbs for P256 in EC implementation [v4]
Xue-Lei Andrew Fan
xuelei at openjdk.org
Wed Nov 30 19:46:20 UTC 2022
On Wed, 30 Nov 2022 07:46:19 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Please add a test that verifies that the worst case calculation still produces correct results. That is:
>
> * build a number where the limb values are as high as possible (2^(numLimbs*bitsPerLimb)-1, or something close)
> * sum that number with itself until numAdds = maxAdds
> * square the result
> * compare the result with the same calculations on BigInteger
It makes senses to me. I would like to have an improvement in FieldGen.java instead, so that no illegal params could be set. Let's see if I could make it before integration of this patch.
-------------
PR: https://git.openjdk.org/jdk/pull/10398
More information about the security-dev
mailing list