RFR: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

Jaikiran Pai jpai at openjdk.org
Tue Oct 4 06:22:11 UTC 2022


On Mon, 3 Oct 2022 14:35:46 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> This PR reduces the execution time of ProxyAuthTest.
> 
> Before this change the test always required at least 3 minutes to complete (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`).
> After this change the test does not open a server socket when it is not necessary.
> 
> The test continues to pass.

Marked as reviewed by jpai (Reviewer).

Thank you Daniel for that explanation. Having looked at the test, it wasn't clear to me what exactly was being done/tested there.

@djelinski, the change looks fine to me. Although we now default to a well known port to which perhaps something already might be listening on a host, based on what Daniel noted, the request will never make it to that target - so this change will not introduce any intermittent failures from what I can see.

The copyright year on that test file will need an update.

-------------

PR: https://git.openjdk.org/jdk/pull/10539


More information about the security-dev mailing list