Integrated: 8294734: Redundant override in AES implementation

[Xue-Lei Andrew Fan]

On Mon, 3 Oct 2022 19:18:20 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> May I have this simple code clean-up patch reviewed?
> 
> In the AES cipher implementation, the override of engineDoFinal() method in the following code is not necessary as it only calls super.  The throws descriptions are missed in the method description.  It may be better to remove this override implementation, rather than fix the method description.
> 
> 
>     /**
>      * Finalize crypto operation with ByteBuffers
>      *
>      * @param input the input ByteBuffer
>      * @param output the output ByteBuffer
>      *
>      * @return output length
>      * @throws ShortBufferException
>      * @throws IllegalBlockSizeException
>      * @throws BadPaddingException
>      */
>     protected int engineDoFinal(ByteBuffer input, ByteBuffer output)
>         throws ShortBufferException, IllegalBlockSizeException,
>         BadPaddingException {
>         return super.engineDoFinal(input, output);
>     }
> 
> ``` 
> 
> Code clean-up, not new regression test added.
> 
> Thanks,
> Xuelei

This pull request has now been integrated.

Changeset: f2c57186
Author:    Xue-Lei Andrew Fan <xuelei at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f2c57186a40bea4d5ad1c3ba010b59e552db624d
Stats:     18 lines in 1 file changed: 0 ins; 18 del; 0 mod

8294734: Redundant override in AES implementation

Reviewed-by: valeriep, wetmore

-------------

PR: https://git.openjdk.org/jdk/pull/10545