RFR: 8294821: Class load improvement for AES crypto engine

Xue-Lei Andrew Fan xuelei at openjdk.org
Wed Oct 5 18:05:22 UTC 2022


On Wed, 5 Oct 2022 17:44:39 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> I wonder if it would be worthwhile to have a static method that could be called in an assert (or in a test using --patch-module) to verify that the various statically initialized arrays are the same than those that would have been computed by the old code?

I did think about the same idea, by putting the code into test codebase or generate the tables with makefile configuration.   Actually, I had the table generation code in my local workspace.  However, I give it up at last because such kind of code is just used one time and may not worthy the resources to maintain it or the power to run it while building/testing.  None of the tables could be wrong, otherwise the algorithm will not work.  The regression test and inter-op testing may be sufficient to approve that the tables are good.

But please let me know, if you have a strong preference to have it, I will try to integrate the table generation code.

-------------

PR: https://git.openjdk.org/jdk/pull/10568


More information about the security-dev mailing list