RFR: 8294987: Streamline DerOutputStream write

Anthony Scarpino ascarpino at openjdk.org
Fri Oct 7 18:43:14 UTC 2022


On Fri, 7 Oct 2022 15:47:49 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Return `this` in various output methods so you can write something like
> 
>         new DerOutputStream().putInteger(1)
>                 .putOctetString("12345".getBytes(StandardCharsets.UTF_8))
>                 .write(AlgorithmId.get("ed25519"))
>                 .writeImplicit((byte)0x80, new DerOutputStream().putUnalignedBitString(ba)).toByteArray();
> 
> No regression test. Trivial pure enhancement.

There are a number of methods that call 'write()' then call 'return this;'  they could just be 'return write()', but if that's a style you prefer, that is fine.

-------------

PR: https://git.openjdk.org/jdk/pull/10608



More information about the security-dev mailing list