RFR: 8294987: Streamline DerOutputStream write [v2]

Anthony Scarpino ascarpino at openjdk.org
Fri Oct 7 20:27:24 UTC 2022


On Fri, 7 Oct 2022 19:52:15 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Return `this` in various output methods so you can write something like
>> 
>>         new DerOutputStream().putInteger(1)
>>                 .putOctetString("12345".getBytes(StandardCharsets.UTF_8))
>>                 .write(AlgorithmId.get("ed25519"))
>>                 .writeImplicit((byte)0x80, new DerOutputStream().putUnalignedBitString(ba)).toByteArray();
>> 
>> No regression test. Trivial pure enhancement.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   just return

Marked as reviewed by ascarpino (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10608



More information about the security-dev mailing list