RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

Aleksei Efimov aefimov at openjdk.org
Sun Oct 9 11:53:55 UTC 2022


On Thu, 6 Oct 2022 16:24:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Refactor checkInput, better reporting for invalid filter patterns
>>  - Merge branch 'master' into JDK-8290368_protocol_specific_factory_filters
>>  - Additional comments/formatting cleanup.
>>  - More tests clean-up. Code/doc comments cleanup.
>>  - Cleanup test comments. Add tests to check that LDAP/RMI filters do not intersect.
>>  - 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation
>
> test/jdk/com/sun/jndi/ldap/objects/factory/LdapFactoriesFilterTest.java line 46:
> 
>> 44:  * @build LDAPServer LDAPTestUtils TestFactory
>> 45:  *
>> 46:  * @run main/othervm LdapFactoriesFilterTest false
> 
> Are any of these filter property cases, malformed and would produce an error from ObjectInputFilter.create?

There were no such cases.
Now, RMI and LDAP tests have been modified to run with malformed filter patterns which produce an error from `ObjectInputFilter.create`. 
Also, new cases were added to check that illegal patterns in one of RMI or LDAP filters not preventing other one from being used.

-------------

PR: https://git.openjdk.org/jdk/pull/10578


More information about the security-dev mailing list