RFR: 8294906: Memory leak in PKCS11 NSS TLS server [v2]

[Daniel Jeliński]

On Fri, 7 Oct 2022 07:42:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> C_DeriveKey with mechanisms `CKM_*_KEY_AND_MAC_DERIVE` always returns mac keys, even if macBits is zero. These keys must be free'd when no longer needed.
>> 
>> Verified that:
>> - SSL server configured with PKCS11-NSS provider leaks memory without this patch, does not leak memory with this patch
>> - The same server continues to function correctly
>> - Existing tier1-3 tests continue to pass with NSS; did not test any other PKCS11 providers
>> - new tests for AES-128-GCM-SHA256 and AES-256-GCM-SHA384 key derivation pass
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check if mac keys are present

Thanks for the review! Comment added.

I was unable to find any working Windows NSS binaries that are less than 3 years old; apparently there are no official builds. I tried using Firefox's NSS, but for some reason Java couldn't load them.
I'll see if I can find a Linux distro with something more recent.

-------------

PR: https://git.openjdk.org/jdk/pull/10594