RFR: 8294997: Improve ECC math operations [v2]

Xue-Lei Andrew Fan xuelei at openjdk.org
Wed Oct 12 14:59:24 UTC 2022


On Wed, 12 Oct 2022 12:43:09 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> This patch rewrites some BigInteger and curve point operations used in EC calculations:
>> - coefficient * 2^power is equivalent to coefficient << power
>> - number mod 2^n is equivalent to number & (2^n-1)
>> - pair of IntegerModuloP operations:
>> t2 = t1+t1
>> t1 = t1+t2
>> is equivalent to t1=t1*3, which is now implemented more efficiently.
>> 
>> Benchmarked the code using not-yet-merged benchmark from #10544. Results on x64 before:
>> 
>> Benchmark        (messageLength)   Mode  Cnt     Score   Error  Units
>> Signatures.sign               64  thrpt   15  1578.907 ± 1.522  ops/s
>> 
>> After:
>> 
>> Benchmark        (messageLength)   Mode  Cnt     Score   Error  Units
>> Signatures.sign               64  thrpt   15  1679.495 ± 3.883  ops/s
>> 
>> Greatest part of the improvement is related to ECOperations changes; BigInteger modifications provide only marginal gains (1584 ops/s without ECOperations changes).
>> 
>> Tier1-3 tests continue to pass.
>
> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright year
>  - Revert DSA changes

Marked as reviewed by xuelei (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10614



More information about the security-dev mailing list