RFR: 8292033: Move jdk.X509Certificate event logic to JCA layer [v2]

Weijun Wang weijun at openjdk.org
Tue Oct 25 14:36:49 UTC 2022


On Tue, 25 Oct 2022 14:30:32 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> test/lib/jdk/test/lib/security/TestCertificate.java line 45:
>> 
>>> 43:     ONE("1000",
>>> 44:         "CN=SSLCertificate,O=SomeCompany",
>>> 45:         "CN=Intermediate CA Cert,O=SomeCompany",
>> 
>> Why remove the spaces? `X500Name::toString` always has them.
>
> Code was modified to use the X509Certificate API (rather than X509CertImpl) 
> 
> it's using the X500Principal#getName() call now. Would it be better to use X500Principal#toString() ?

If you are only writing there and not parsing the string, then I assume either is OK. Still, less change is better.

-------------

PR: https://git.openjdk.org/jdk/pull/10422



More information about the security-dev mailing list