RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

[Sean Mullan]

You are currently receiving this informational message with the original email attached. We need your help in notifying the team or sender responsible for this mail flow to ensure future email is delivered properly.

The host that sent this message is not compliant with Oracle's email security policy (DMARC). Please notify the person(s) responsible for this message and share the content below so they can take actions to resolve their issue.

If you have no idea who is responsible, then please address the #ww-oracle-dmarc slack channel for assistance.

Deadlines
	• We plan to move to quarantine non-compliant messages on October 26th (delayed due to change freeze).  After this date, if the issues are not fixed, messages will be held in a folder on our email gateway and will not be delivered to you.
	• We will then move to reject on November 22nd.  After this date, messages will be rejected.

For more technical resources and information, see:
https://confluence.oci.oraclecorp.com/display/EMAIL/DMARC+for+Oracle+IT+and+Email+Delivery+Frequently+Asked+Questions
https://confluence.oraclecorp.com/confluence/display/OITGLOBAL/DMARC+Global+FAQ

Thank you in advance for your attention to this matter.

----------------------------------------------------------------------
On Wed, 26 Oct 2022 14:33:26 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > Change looks good. Does it need a CSR?
> 
> Hi Martin , from what I read here https://wiki.openjdk.org/display/csr/CSR+FAQs no CSR is needed. But I am no expert on the topic so maybe someone else has an opinion on this ?

It does not require a CSR.

> While looking at this change, I considered adding a constructor (String,Throwable) to InvalidAlgorithmParameterException and use it in security coding to simplify coding, but I did not do this in this change; I think adding a constructor (String,Throwable) to InvalidAlgorithmParameterException would indeed need a CSR .

I think you mean `InvalidParameterException`. `InvalidAlgorithmParameterException` has a ctor that takes a cause. Can you file an RFE?

Note: I don't know if there is much benefit to specifying the exception message as the first argument, but I'm ok with leaving this as is if you want to avoid too many changes. For example:

`throw new IllegalArgumentException(e.getMessage(), e)`

Maybe we should just change these to:

`throw new IllegalArgumentException(e)`

I think the main benefit is that you get a localized message, if applicable.

-------------

PR: https://git.openjdk.org/jdk/pull/10726