RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

Matthias Baesken mbaesken at openjdk.org
Thu Oct 27 08:03:40 UTC 2022


On Wed, 26 Oct 2022 15:22:41 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More causes
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PSSSignature.java line 212:
> 
>> 210:         } catch (NullPointerException npe) {
>> 211:             throw new SignatureException("Unsupported digest: " +
>> 212:                     digestAlg, npe);
> 
> I don't think the `NullPointerException` adds any value here. I would leave that out.

okay, I removed this change.

-------------

PR: https://git.openjdk.org/jdk/pull/10726



More information about the security-dev mailing list