RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

[vpaprotsk]

On Mon, 24 Oct 2022 23:38:16 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> vpaprotsk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   extra whitespace character
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 8306:
> 
>> 8304:   assert(dst != xnoreg, "sanity");
>> 8305:   InstructionMark im(this);
>> 8306:   InstructionAttr attributes(vector_len, /* vex_w */ true, /* legacy_mode */ false, /* no_mask_reg */ false, /* uses_vl */ true);
> 
> no_mask_reg should be set to true here as we are not setting the mask register here.

done

> src/hotspot/cpu/x86/stubRoutines_x86.cpp line 83:
> 
>> 81: address StubRoutines::x86::_join_2_3_base64 = NULL;
>> 82: address StubRoutines::x86::_decoding_table_base64 = NULL;
>> 83: address StubRoutines::x86::_poly1305_mask_addr = NULL;
> 
> Please also update the copyright year to 2022 for stubRoutines_x86.cpp and hpp files.

done. (hpp seemed ok)

> src/hotspot/cpu/x86/vm_version_x86.cpp line 925:
> 
>> 923:     _features &= ~CPU_AVX512_VBMI2;
>> 924:     _features &= ~CPU_AVX512_BITALG;
>> 925:     _features &= ~CPU_AVX512_IFMA;
> 
> This should also be done under is_knights_family().

done

-------------

PR: https://git.openjdk.org/jdk/pull/10582